D21746: [autotests] Fix remaining autotests with failing border calculation

zzag added a comment.


  DontCrashGlxgearsTest fails on my machine
  
    [vlad@lithium kwin]$ rm -rf ~/.qttest/
    [vlad@lithium kwin]$ dbus-run-session bin/testDontCrashGlxgears 
    QFile::remove: Empty or null file name
    ********* Start testing of KWin::DontCrashGlxgearsTest *********
    Config: Using QtTest library 5.13.0, Qt 5.13.0 (x86_64-little_endian-lp64 shared (dynamic) debug build; by GCC 8.3.0)
    _XSERVTransSocketUNIXCreateListener: ...SocketCreateListener() failed
    _XSERVTransMakeAllCOTSServerListeners: server already running
    glamor: No eglstream capable devices found
    glamor: 'wl_drm' not supported
    Missing Wayland requirements for glamor GBM backend
    Missing Wayland requirements for glamor EGLStream backend
    Failed to initialize glamor, falling back to sw
    The XKEYBOARD keymap compiler (xkbcomp) reports:
    > Warning:          Unsupported high keycode 372 for name <I372> ignored
    >                   X11 cannot support keycodes above 255.
    >                   This warning only shows for the first high keycode.
    > Internal error:   Could not resolve keysym XF86MonBrightnessCycle
    > Internal error:   Could not resolve keysym XF86RotationLockToggle
    Errors from xkbcomp are not fatal to the X server
    X-Server started on display :1
    PASS   : KWin::DontCrashGlxgearsTest::initTestCase()
    The XKEYBOARD keymap compiler (xkbcomp) reports:
    > Warning:          Unsupported maximum keycode 569, clipping.
    >                   X11 cannot support keycodes above 255.
    > Warning:          Unsupported high keycode 372 for name <I372> ignored
    >                   X11 cannot support keycodes above 255.
    >                   This warning only shows for the first high keycode.
    > Internal error:   Could not resolve keysym XF86MonBrightnessCycle
    > Internal error:   Could not resolve keysym XF86RotationLockToggle
    Errors from xkbcomp are not fatal to the X server
    QWARN  : KWin::DontCrashGlxgearsTest::testGlxgears() Module 'org.kde.kwin.decoration' does not contain a module identifier directive - it cannot be protected from external registrations.
    QWARN  : KWin::DontCrashGlxgearsTest::testGlxgears() QQmlComponent: Component is not ready
    QWARN  : KWin::DontCrashGlxgearsTest::testGlxgears() org.kde.kwindowsystem.keyserver.x11: X11 implementation of KKeyServer accessed from non-X11 platform! This is an application bug.
    FAIL!  : KWin::DontCrashGlxgearsTest::testGlxgears() 'mousePressevent.isAccepted()' returned FALSE. ()
       Loc: [/home/vlad/Workspace/KDE/src/kde/workspace/kwin/autotests/integration/dont_crash_glxgears.cpp(86)]
    QWARN  : KWin::DontCrashGlxgearsTest::testGlxgears() QProcess: Destroyed while process ("glxgears") is still running.
    PASS   : KWin::DontCrashGlxgearsTest::cleanupTestCase()
    Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 364ms
    ********* Finished testing of KWin::DontCrashGlxgearsTest *********
    QSocketNotifier: Invalid socket 19 with type Read, disabling...

INLINE COMMENTS

> maximize_test.cpp:145
> +
> +    // If no borders, there is only the initial geometry shape cahnge, but none through border resizing.
> +    QCOMPARE(geometryShapeChangedSpy.count(), hasBorders ? 2 : 1);

There is a typo in the word "change."

I wonder why the linter is silent.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D21746

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart