D22119: [RFC] [autotests] In internal window test remove spy waits or guard them

romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
romangg requested review of this revision.

REVISION SUMMARY
  The internal window test is failing on CI because the client add spy waits
  are not triggered. The signal has been emitted already at this point.
  
  Removing them fixes this (the condition is still checked by subsequent
  count verify on the spy) in all but one instance. In this case the wait
  needs to be guarded.
  
  Is there a more general approach to it? Always guarding is ugly. Also when
  was this test regression introduced? In the past we must have had some
  slack until the signal was fired to start the wait call.

TEST PLAN
  Internal window test passes with this patch again.

REPOSITORY
  R108 KWin

BRANCH
  fixInternalWindowTest

REVISION DETAIL
  https://phabricator.kde.org/D22119

AFFECTED FILES
  autotests/integration/internal_window.cpp

To: romangg, #kwin
Cc: kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart