D22119: [RFC] [autotests] In internal window test remove spy waits or guard them

Roman Gilg <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
romangg added a comment.


  In D22119#487289 <https://phabricator.kde.org/D22119#487289>, @davidedmundson wrote:
  
  > One nice pattern when it's not important whether something is processed an event loop or might have been done directly or via a previous event loop is:
  >
  > QVERIFY(clientAddedSpy.count() ==1 || clientAddedSpy.wait());
  >
  > we do that in a few places.
  
  
  That's definitely a nice pattern and if we already use it at other places I will change the diff to that. Only downside I could see is that it does not explicitly check that the signal has been sent only once when waiting. But that's not necessary here.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22119

To: romangg, #kwin
Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.