D22195: WIP: Split Compositor class in Wayland and X child classes

Roman Gilg <[email protected]> Mon, 1 Jul 2019 22:12:58 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

romangg added a comment.

  In D22195#489295 <https://phabricator.kde.org/D22195#489295>, @zzag wrote:

  > > options->setCompositingInitialized(false); // TODO: why?
  >
  > I have a feeling that it has something to do with
  >
  > https://github.com/KDE/kwin/blob/aa26125635c29755c837ffbacdfcab62e5d05e76/workspace.cpp#L1053-L1064

  To me it looks like some sort of optimization to not read in the config files more often than necessary. See text at:
  https://cgit.kde.org/kwin.git/tree/options.cpp#n959

  But I could imagine this is some premature optimization and on Wayland most of the compositing options  (or all besides animation speed?) are ignored anyway.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22195

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart