D22209: [effects/screenshot] Disable screenshot to file on Wayland

graesslin created this revision.
graesslin added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
graesslin requested review of this revision.

REVISION SUMMARY
  One of the biggest security issues on X11 was that any application could
  take screenshots. On Wayland we addressed this by making the screenshot
  process interactive. The user has to confirm explicitly that a
  screenshot is taken. But our API still allows to create a screenshot and
  save it directly to a temporary file. It shows a notification, but
  nevertheless it is a small security issue.
  
  Thus this change addresses it by sending a dbus error in case the
  methods are called on Wayland.

TEST PLAN
  Run nested session before and after change and used qdbusviewer
  to call screenshot. Before path was returned, after change no path was returned.

REPOSITORY
  R108 KWin

BRANCH
  screenshot-unsupported-wayland

REVISION DETAIL
  https://phabricator.kde.org/D22209

AFFECTED FILES
  effects/screenshot/screenshot.cpp

To: graesslin, #kwin
Cc: kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart