D21996: [autotests] Test placement strategies
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in placement.cpp:151 > Name of this variable is misleading. It leaves impression that this is a ShellClient. Perhaps don't use `auto`? Done, but we need to take this "auto" discussion to frameworks-devel and make an actual policy. > zzag wrote in placement.cpp:61-66 > > Why would someone be generating doxygen of an internal class of an autotest? > > Perhaps I should have asked you this question. Initially, this method had a legit Doxygen comment with "wrong" terminator. Yeah, I had it because I wanted to indicate the comment was describing what the function does, not commenting the code. But then as that went into a pointless discussion about doxygen, I didn't bother. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D21996 To: davidedmundson, #kwin Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart