D22218: Use new slot syntax in Compositor class
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added a comment. In D22218#489700 <https://phabricator.kde.org/D22218#489700>, @davidedmundson wrote: > TimerEvent shouldn't really be made private. > We typically don't change accessibility of superclass methods. We don't? It's not really a make-or-break thing for me, but what's the rationale for that? It seems to me more sensible to have the most narrow accessibility used when possible and if there are no child classes to begin with don't declare something protected. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22218 To: romangg, #kwin Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart