D22218: Use new slot syntax in Compositor class

Roman Gilg <[email protected]> Tue, 2 Jul 2019 22:51:54 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

romangg added inline comments.

INLINE COMMENTS

> zzag wrote in composite.h:170-171
> Please keep it protected.

Reply to what I asked first in this context.

> zzag wrote in composite.h:85
> In general I don't see why making it Q_INVOKABLE is better than keeping as a slot. Either keep it as Q_SLOT or use QTimer::singleShot(0).

Why not Q_INVOKABLE?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22218

To: romangg, #kwin
Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart