D22277: Save Compositor state in single variable
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added inline comments. INLINE COMMENTS > zzag wrote in composite.cpp:321-323 > I have one remaining question. Why did you drop this if statement? > > Relevant commit: 50ef02fa1b30c2c22d3cabc4f620e1654f9a5eae <https://phabricator.kde.org/R108:50ef02fa1b30c2c22d3cabc4f620e1654f9a5eae>. Good question. startupWithWorkspace is either called directly from start() (always in X case) or by signal (in Wayland case on startup). That should in both cases happen only once. I.e. we can split the signal out to future Wayland Compositor child class and disconnect the signal after it was received once. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22277 To: romangg, #kwin Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart