D22255: Fix maximize Apply Now rule
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added a comment. In D22255#492139 <https://phabricator.kde.org/D22255#492139>, @romangg wrote: > That we need this conditional removed indicates that the structure is wrong how we check for the maximize rule. And looking at the code we have methods `maximize`, `setMaximize` and `changeMaximize` in quick succession. I'm pretty sure we could remove at least one of these three. `maximize` is just a wrapper around `setMaximize`, another name for `changeMaximize` is `doMaximize` (a better one). REPOSITORY R108 KWin BRANCH make-maximize-apply-now-rules-work REVISION DETAIL https://phabricator.kde.org/D22255 To: zzag, #kwin, romangg Cc: romangg, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart