D22295: Remove scene check on repaints

Roman Gilg <[email protected]> Mon, 8 Jul 2019 09:18:22 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

romangg added a comment.


  In D22295#492097 <https://phabricator.kde.org/D22295#492097>, @zzag wrote:
  
  > > If not we later abort anyway because the state is not 'On'.
  >
  > Can you provide link to this code?
  
  
  https://cgit.kde.org/kwin.git/tree/composite.cpp#n809

INLINE COMMENTS

> zzag wrote in composite.cpp:583-584
> Is it correct though? We'll keep adding repaint regions even if compositing is disabled.

Yea, shouldn't be an issue. We can add as many we like and when compositing gets enabled again we do a repaint of the accumulated region (probably we do a full repaint then anyway).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22295

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart