D22193: [effects] Mark effect classes as final

Roman Gilg <[email protected]> Tue, 9 Jul 2019 12:47:53 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

romangg added a comment.


  In D22193#492785 <https://phabricator.kde.org/D22193#492785>, @zzag wrote:
  
  > > You can't subclass an effect by accident.
  >
  > From technical point of view you're absolutely right, there's no point for it. On the other side marking these classes as final explicitly, improves readability of the code a bit (imho; that's perhaps subjective matter).
  
  
  For readability sometimes code can also be too verbose. It's pretty clear that these effects normally won't get sub classed again. Or in which cases do you think a reader could assume otherwise?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22193

To: zzag, #kwin
Cc: romangg, davidedmundson, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart