D22195: Split Compositor class in Wayland and X11 child classes
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added inline comments. INLINE COMMENTS > zzag wrote in composite.h:49 > As a "WebKit coding style"-head, I agree that putting a whitespace before a pointer doesn't make sense because it's part of the type, but we follow Kdelibs/Frameworks coding style, which dictates that a whitespace has to be put before pointers or references. It doesn't matter whether it's a function or a template argument, you have to put a whitespace. Similar story with clang-format. If we run it, the asterisk will be aligned to right. > > Please notice that I didn't "invent" or "make out" this rule. KWin doesn't follow Kdelibs/Frameworks coding style per se since it's not part of frameworks. Let's discuss this at KWin sprint. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22195 To: romangg, #kwin Cc: anthonyfieroni, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart