D22474: Install KPackages with kpackage_install_package

Aleix Pol Gonzalez <[email protected]> Mon, 15 Jul 2019 18:39:44 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

apol added a comment.


  In D22474#495857 <https://phabricator.kde.org/D22474#495857>, @zzag wrote:
  
  > Is it possible to use kpackage_install_package inside of each effect's CMakeLists.txt file? The problem is that now "toplevel" effect directories contain only one directory - package. We should either keep CMakeLists.txt or flatten everything out (I'd prefer the former).
  
  
  I don't think that's a good idea. Then you're hiding the call for no reason.
  
  We could consider moving all packages up, but that's also something that could have been done earlier and nobody did the change. It can be revisited in a different patch.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22474

To: apol, #kwin
Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart