D22571: Allow blacklisting some wayland interfaces

zzag added a comment.


  Some style nitpicks.

INLINE COMMENTS

> wayland_server.cpp:76-77
>  #include <QWindow>
> +#include <QCryptographicHash>
> +#include <KServiceTypeTrader>
>  

QCryptographicHash needs to go first in this block. KServiceTypeTrader include directory needs to be above this include block.

> wayland_server.cpp:231
> +        const auto servicesFound = KServiceTypeTrader::self()->query(QStringLiteral("Application"), serviceQuery);
> +        qCDebug(KWIN_CORE) << "checking" << serviceQuery << servicesFound.count();
> +

The debug output needs to be more verbose. At least we have some idea what origin of this message is.

though I think we can just drop this one.

> wayland_server.cpp:255
> +
> +        {
> +            auto requestedInterfaces = client->property("requestedInterfaces");

Why a new scope is introduced?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22571

To: apol, #plasma, #kwin
Cc: zzag, broulik, graesslin, davidedmundson, kwin, LeGast00n, fmonteiro, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart