D23069: Remove dead code
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added a comment. In D23069#509733 <https://phabricator.kde.org/D23069#509733>, @gladhorn wrote: > I just removed the obviously dead bits behind an if (false). If someone wants to bring it back, it's always in the git history. I don't care either way, but to me reducing lines of code is generally a good thing. I agree and I don't see tabs coming back soon either. But removing the control mechanism in UserActionsMenu just partly and then leaving few other bits of potentially now even more confusing zombie code behind I would also try to omit. Also if we want to get it back from git history at some point it would be nice to get it back from a single removing commit and not several ones removing small parts one after the other. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D23069 To: gladhorn, #kwin Cc: romangg, graesslin, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart