D23086: Be consistent about touch point id type: Qt uses qint32
Frederik Gladhorn <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
gladhorn added a comment. In D23086#510317 <https://phabricator.kde.org/D23086#510317>, @romangg wrote: > In D23086#510314 <https://phabricator.kde.org/D23086#510314>, @zzag wrote: > > > Someone "fixed" these warnings a while ago, but you reverted the fix. > > > I know. I reverted because it broke functionality. So there was no fix. > > >> This makes sense because libinput provides (non-negative) int32 ids/slots. > > > > Even if it makes sense, the warnings have to be fixed. Comparing signed and unsigned numbers without taking extra measures is bad. > > "This makes sense" as in this fix here. If libinput would provide uint32 ids it would not make sense. I though these were Qt touch points, interesting. In any case, I hope this is more complete than just casting in 16e904592ae4fe0a04ef61d42c9a114c62997c8e <https://phabricator.kde.org/R108:16e904592ae4fe0a04ef61d42c9a114c62997c8e>. What is the best way to test these? I'll run my desktop with the change. I don't use the touch screen that often though. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D23086 To: gladhorn, #kwin Cc: zzag, romangg, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart