D23102: Reduce duplicate code calculating popup position
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > zzag wrote in useractions.cpp:154-162 > I don't see why we have to ensure that QMenu doesn't fall off screen. QMenu already does that for us. Besides that our code is incomplete(only one out of three cases is handled) and incorrect(`y + popupHeight >= area.height()` is wrong). > > Remove `if (y != pos.top())` and everything that goes inside. Why do we have this check? Well, that's a good question! I'd like to know why ;-) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D23102 To: gladhorn, #kwin, romangg, zzag Cc: zzag, romangg, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart