D23582: [platforms/x11] Make X11WindowedOutput::init() private

davidedmundson added a comment.


  > In either case encapsulation is "meh," but at least it's less severe with friend class.
  
  It just swaps one bad thing for one equally bad.
  Now you have the hypothetical case of some rogue future coder in X11WindowedBackend modifying m_window directly causing a crash.
  
  Anyway, in this case the args and everything can just go in the constructor. You solve the case of being called multiple times and from which class all in one go.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23582

To: zzag, #kwin
Cc: davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart