D23582: [platforms/x11] Make X11WindowedOutput::init() private
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. And I think we can stay keep the public init and switch to something better when we have it. I don't want to check back all the time if a private field has been manipulated by the backend class when working on the code. If you want to improve the code get rid of the necessity to have the DrmBackend class be friend with DrmOutput. David also gave you a good pointer on what to do here if you really can't stand this public init function: add the arguments to the constructor. But even then the "improvement" wouldn't be worth the time to do it. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D23582 To: zzag, #kwin, romangg Cc: romangg, davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart