D23591: [platforms/drm] Disable orientation sensor for now
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg created this revision. romangg added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. romangg requested review of this revision. REVISION SUMMARY The orientation sensor causes a crash when disabling and afterwards enabling again the first output in a multi-monitor environment. This is difficult to debug, since gdb does not provide good information and with valgrind it does not crash indicating that it is a race. But output of gdb and valgrind together shows that the orientation sensor is responsible. For now disable the orientation sensor. Reasons are: - Output enablement is a basic feature and must work first flawlessly before thinking about advanced features. - The orientation sensor did never really work flawlessly according to user feedback. - The orientation sensor hooks into Screens class which will go away. A rewrite of the sensor is necessary. TEST PLAN When orientation sensor is disable dthe first output can be disabled and enabled again REPOSITORY R108 KWin BRANCH disableOrientationSensorOnDrm REVISION DETAIL https://phabricator.kde.org/D23591 AFFECTED FILES plugins/platforms/drm/drm_output.cpp To: romangg, #kwin Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart