D23669: Generate mipmaps for image down-scaling

davidedmundson added a comment.


  Thanks, I was under the impression we needed to enable smooth filtering, but to me the output always looked the same.

INLINE COMMENTS

> scene_opengl.cpp:1383
> +    if (waylandServer()) {
> +        filter = GL_LINEAR;
> +    } else {

That's a bit lazy.

Always using GL_LINEAR AFAIK is fine, but always generating mipmaps has a cost.

We should be able to do some sort of

if (windowPixmap->surface()->scale() != output->scale())

We also probably only want to generate mipmaps if the contents have changed.

GLTexture has a dirty() flag which signifes this.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23669

To: romangg, #kwin
Cc: davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart