D23748: [wayland] Avoid compare to unintialised value in keyboard repeat

David Edmundson <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If we get a key event for which
  
  if (m_xkb->shouldKeyRepeat(key) &&
  waylandServer()->seat()->keyRepeatDelay() != 0) fails
  
  m_key will be unitialised and on release we have a compare against
  unitialised memory.
  
  Won't do any harm, it'll just stop a timer that isn't running, but
  valgrind complains.
  
  0 is the value QKeyEvent uses when nativeScanCode is unknown so a safe
  initial values.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23748

AFFECTED FILES
  keyboard_repeat.h

To: davidedmundson, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.