D23913: [kcmkwin/kwineffects] Use new Kirigami ListSectionHeader component

Nathaniel Graham <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
ngraham added inline comments.

INLINE COMMENTS

> Effect.qml:67
>  
> -            Kirigami.Heading {
>                  Layout.fillWidth: true

Are you sure about this change? Semantically, it is indeed a heading. If the purpose of this was to make the list item headings smaller than the section headers by using a Label, you can keep it as a Heading but raise the level to 5, which has the same size as a Label.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23913

To: GB_2, #kwin, #plasma, #vdg, davidedmundson
Cc: ngraham, kwin, #vdg, #plasma, #kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, gladhorn, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.