D24153: [nightcolor] Use local time in Automatic and Location mode

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  Currently Night Color doesn't handle time zones very well. For example,
  if the user's time zone is UTC-8, then computed timings of sunrise and
  sunset (in UTC) will be a bit gibberish as sunset occurs before sunrise
  rather than vice versa.
  
  This change switches relevant parts of Night Color to local time in
  order to fix expectations about the order of morning and evening in
  updateSunTimings() method as well to simplify the code a bit (dealing
  with UTC and local time can be painful sometimes).
  
  BUG: 412211
  FIXED-IN: 5.17.0

REPOSITORY
  R108 KWin

BRANCH
  fix-colorcorrect

REVISION DETAIL
  https://phabricator.kde.org/D24153

AFFECTED FILES
  colorcorrection/manager.cpp
  colorcorrection/manager.h
  colorcorrection/suncalc.cpp
  colorcorrection/suncalc.h

To: zzag, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart