D22810: Port QPA away from Wayland

romangg added inline comments.

INLINE COMMENTS

> internal_window.cpp:216
> +
> +    QMetaObject::invokeMethod(kwinApp()->platform(), "setVirtualOutputs", Qt::DirectConnection, Q_ARG(int, 2));
>  }

Feels a bit odd to do it in the cleanup. But not critical.

> effects.cpp:1096
> -    if (auto u = Workspace::self()->findUnmanaged(w->winId())) {
> -        return u->effectWindow();
>      }

On X is this not needed anymore? I.e. on X all internal clients now also are of type `InternalClient` and not anymore `Unmanaged`? If so, this needs to be mentioned in the commit message.

> scene_qpainter.cpp:406
> +    if (!surface()) {
> +        // That's an internal client.
> +        m_image = internalImage();

Why can't it be an X client?

> pointer_input.cpp:559
> +    if (!focusNow || !focusNow->surface() || decoration()) {
> +        // no new surface or on internal window or on decoration -> cleanup
> +        warpXcbOnSurfaceLeft(nullptr);

Use full sentences.

> workspace.h:652
>  
> +    friend class InternalClient;
> +

Is this really necessary?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22810

To: zzag, #kwin, davidedmundson
Cc: romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart