D24215: [libkwineffects] Introduce API to easily show a QtQuick scene in an effect

zzag added a comment.


  Bump API version in kwineffects.h
  
  I didn't test this patch, however I think Invert effect won't be able to "invert" EffectQuickView's.

INLINE COMMENTS

> kwineffectquickview.cpp:87
> +
> +    bool usingGl = d->m_view->rendererInterface()->graphicsApi() == QSGRendererInterface::OpenGL;
> +

Mark as const

> kwineffectquickview.cpp:90
> +    if (!usingGl) {
> +        qDebug() << "QtQuick Software rendering mode detected";
> +        d->m_useBlit = true;

Use qCDebug.

> kwineffectquickview.cpp:117
> +            qDebug() << "Extra debug:";
> +            qDebug() << "our context: " << d->m_glcontext.data();
> +            qDebug() << "share context: " << s_shareContext.get();

You don't need to put whitespace after colon.

> kwineffectquickview.cpp:196
> +    }
> +    QMouseEvent *me = dynamic_cast<QMouseEvent *>(e);
> +    const QPoint widgetPos = d->m_view->mapFromGlobal(me->pos());

Use static_cast

> kwineffectquickview.h:87
> +    ~EffectQuickView();
> +    ;
> +

stray semicolon

> scene_opengl.cpp:862
> +{
> +    GLShader* shader = ShaderManager::instance()->pushShader(ShaderTrait::MapTexture);
> +    const QRect rect = w->geometry();

Style: wrong alignment of `*`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24215

To: davidedmundson, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart