D24240: [effects/presentwindows] Port present windows to EffectQuickView
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. davidedmundson requested review of this revision. REVISION SUMMARY Removes over 100 lines of rather confusing code, implicitly introduces a sharedEngine. Doesn't perform hide/show by moving a window offscreen. As for the freeze, proving that EffectQuickView covers this case without lots of extra C++ is an important pre-requisite for ever moving this effect to a magic declarative API. General code structure remains the same. TEST PLAN Opened present windows REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D24240 AFFECTED FILES effects/presentwindows/main.qml effects/presentwindows/presentwindows.cpp effects/presentwindows/presentwindows.h To: davidedmundson, #kwin Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart