D24084: Migrate kwin animation speed to kdeglobals

David Edmundson <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
davidedmundson added inline comments.

INLINE COMMENTS

> fvogt wrote in kwin-5.18-move-animspeed.py:1
> > python doesn't necessarily means python2, e.g. Python 3 is default on Arch Linux.
> 
> Yes, but in other cases it does mean python2. The PEP about that will probably never be implemented everywhere (and is IMO also wrong, a script has to state whether it's 2 or 3 compatible).
> 
> > Does it really matter though?
> 
> Yes. Currently without patching kwin5 would not be installable as /bin/env doesn't exist leading to dependency issues.
> Ignoring that, it would be the only package in a default installation pulling in python 2 again, which is a regression.

It does not need python2. 
It's written and tested against python3.

My understanding was that /bin/env was the "correct" way to choose python in weird distros.

I ideally want to avoid having some cmake stuff and then reconfiguring this script. If hardcoding /usr/bin/python3 works for distros, that's more than fine with me.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D24084

To: davidedmundson, zzag
Cc: lbeltrame, fvogt, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.