D24862: Port one of session management connections state to a custom API
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added a comment. > I wonder though whether we could put more responsibility on it, e.g. loading and storing session. I don't ask you to implement that or anythin That's my longer term plan :D : https://phabricator.kde.org/T11882 I had to split it as the ksmserver side got a bit mental (but in a good way) INLINE COMMENTS > zzag wrote in workspace.cpp:1834 > Put whitespace between `//` and the text. I can't wait for clang-format! > zzag wrote in workspace.h:480-485 > Hmm, that's kinda domain of SessionManager. Also, the last one doesn't qualify as a slot. > > What do you think about moving these two to SessionManager? Yeah, I was torn originally, so no objections. My reasoning against was that I didn't want to have the state in one place and Workspace::sessionSaving() in another, but I could port all the relevant code calling that. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D24862 To: davidedmundson, #kwin Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart