D25366: Fix the order of arguments passed to changeMaximize method

Vlad Zahorodnii <[email protected]> Mon, 18 Nov 2019 13:08:39 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag added a comment.


  In D25366#564093 <https://phabricator.kde.org/D25366#564093>, @davidedmundson wrote:
  
  > Urgh, I'm sure this is the second case I've seen of this at least.
  
  
  Yeah, the first case was about the wrong order of parameters in ShellClient::changeMaximize.
  
  > Lets maybe add a changeMaximise(Qt::Orientations) overload and phase this out.
  
  Do you want me to do it in this revision or another one?

REPOSITORY
  R108 KWin

BRANCH
  foobar

REVISION DETAIL
  https://phabricator.kde.org/D25366

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart