D25507: Set orientation from DRM on fallback

Roman Gilg <[email protected]> Tue, 26 Nov 2019 10:09:18 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

romangg added a comment.


  In D25507#567590 <https://phabricator.kde.org/D25507#567590>, @zzag wrote:
  
  > Thank you for looking into this! The way conversion between `Qt::ScreenOrientations` and `DeviceInterface::Transform` is done seems to be wrong.
  >
  > Mixing both `Qt::PortraitOrientation` and `Qt::InvertedPortraitOrientation` doesn't make sense. Wouldn't it be better to introduce a screen transformation enum and use it instead of `Qt::ScreenOrientations`?
  
  
  Yes, it would be better I believe. But I wanted to first try to fix the current approach before thinking about replacing it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25507

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart