D25558: Use Transform enum internally
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > romangg wrote in abstract_wayland_output.cpp:154 > Forgot to add it. Does it really make a difference in C++ though? To my knowledge it doesn't. Yes, it does make a difference. Using `static` will result in symbols local to the translation unit. Using `inline` will result in weak symbols. The second thing is that `inline` just gives a hint to inline the function. The compiler may ignore that hint, but it can also inline functions that are not marked with the inline keyword. So, making functions inline in this case is kind of pointless. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D25558 To: romangg, #kwin, zzag Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart