D25610: [x11] Name client pixmap instead of frame pixmap
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY Since KDE 4.2 - 4.3 times, KWin doesn't paint window decorations on real X11 windows, except when compositing is turned off. This leaves us with a problem. The actual client contents is inside a larger texture with no useful pixel data around it. This and decoration texture bleeding are the main factors that contribute to 1px gap between the server-side decoration and client contents with effects such as wobbly windows, and zoom. Another problem with naming frame pixmap instead of client pixmap is that it doesn't quite go along with wayland. It only makes more difficult to abstract window quad generation in the scene. Since we don't actually need the frame window when compositing is on, there is nothing that holds us from redirecting client windows instead of frame windows. This will help us to fix the texture bleeding issue and also help us with the ongoing redesign of the scene. TEST PLAN X11 clients are still composited. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D25610 AFFECTED FILES composite.cpp deleted.cpp deleted.h effects.cpp events.cpp geometry.cpp plugins/scenes/opengl/scene_opengl.cpp scene.cpp scene.h toplevel.cpp toplevel.h x11client.cpp x11client.h To: zzag, #kwin Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart