D25663: Initial support for tablets on Wayland

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  Now it's fucked up all over the place.

INLINE COMMENTS

> debug_console.cpp:494
> +    QString text = s_hr + s_tableStart + tableHeaderRow(i18n("Tablet Tool")) +
> +        tableRow(i18n("EventType"), typeString) +
> +        tableRow(i18n("Position"),

better before. `+` in front

> debug_console.cpp:510
> +    QString buttons;
> +    for (uint b : pressedButtons)
> +        buttons += QString::number(b) + ' ';

brackets

> debug_console.cpp:523
> +    QString buttons;
> +    for (uint b : pressedButtons)
> +        buttons += QString::number(b) + ' ';

brackets

> debug_console.cpp:527
> +    QString text = s_hr + s_tableStart + tableHeaderRow(i18n("Tablet Pad Button")) +
> +        tableRow(i18n("Pressed Buttons"), buttons) + s_tableEnd;
> +

`+` in front

> debug_console.cpp:536
> +    QString text = s_hr + s_tableStart + tableHeaderRow(i18n("Tablet Pad Strip")) +
> +        tableRow(i18n("Number"), number) + tableRow(i18n("Position"), position) +
> +        tableRow(i18n("isFinger"), isFinger) + s_tableEnd;

`+` in front

> debug_console.cpp:546
> +    QString text = s_hr + s_tableStart + tableHeaderRow(i18n("Tablet Pad Ring")) +
> +        tableRow(i18n("Number"), number) + tableRow(i18n("Position"), position) +
> +        tableRow(i18n("isFinger"), isFinger) + s_tableEnd;

`+` in front

> input.cpp:1975
> +
> +        connect(conn,
> +                &LibInput::Connection::tabletToolEvent,

clang-format stupid

> input.h:98
>      };
> +    enum TabletEventType { Axis, Proximity, Tip };
>      ~InputRedirection() override;

clang-format stupid

> connection.h:134
>  
> +    void tabletToolEvent(KWin::InputRedirection::TabletEventType type,
> +                         const QPointF &pos,

unnecessary many lines. group xTilt, yTilt etc.

> events.h:200
> +    bool xHasChanged() const
> +    {
> +        return libinput_event_tablet_tool_x_has_changed(m_tabletToolEvent);

clang-format stupid

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25663

To: apol, #plasma, #kwin, romangg
Cc: romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart