D25663: Initial support for tablets on Wayland

romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> input.h:233
> +    TabletInputRedirection *tablet() const
> +    {
> +        return m_tablet;

bracket

> events.h:281
> +    }
> +    // uncomment when depending on libinput 1.14 or when implementing totems
> +    //     qreal sizeMajor() const { return

For code comments please use proper punctuation and capitalization.

> romangg wrote in events.h:200
> clang-format stupid

If you define member functions in the class itself these brackets must be behind the function name, i.e.:

  bool xHasChanged() const {
  ....
  }

> tablet_input.cpp:124
> +    input()->processSpies(std::bind(
> +        &InputEventSpy::tabletToolButtonEvent, std::placeholders::_1, m_toolPressedButtons));
> +    input()->processFilters(std::bind(

Split like this:

  input()->processSpies(std::bind(&InputEventSpy::tabletToolButtonEvent, std::placeholders::_1,
                                  m_toolPressedButtons));

Below as well.

> tablet_input.cpp:131
> +{
> +    if (isPressed)
> +        m_padPressedButtons.insert(button);

Brackets!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25663

To: apol, #plasma, #kwin, romangg
Cc: davidedmundson, romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart