D25663: Initial support for tablets on Wayland
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added inline comments. INLINE COMMENTS > zzag wrote in input.h:233 > Only in a few places... but I'd like to point out that putting the opening brace and the method prototype on the same line goes against the coding style. I haven't seen these places. I always see in KWin code opening brackets on same line in this case. So I would prefer to be consistent in deviating from coding style here. Note also that getters `keyboard()`, `pointers()`,... directly above this new getter have opening brackets on the same line. In the end best would be to always have member function definitions in the cpp file. But for small getters it's really a hassle... REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D25663 To: apol, #plasma, #kwin, romangg Cc: zzag, davidedmundson, romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart