D25906: [platforms/drm] Add hardware transformation API

Vlad Zahorodnii <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> drm_output.cpp:654
> + {
> +    using OutTrans = DrmOutput::Transform;
> +    using PlaneTrans = DrmPlane::Transformation;

Use full name, e.g. OutputTransform.

> drm_output.cpp:703
> +
> +        if (!qEnvironmentVariableIsSet("KWIN_DRM_SW_ROTATIONS_ONLY") &&
> +                (m_primaryPlane->supportedTransformations() & planeTransform) &&

Please omit "rotation" in the environment variable name and use something more generic, e.g. "output transforms," etc.

> drm_output.h:92
> +     */
> +    bool hardwareTransforms() const;
> +

Rename it to `supportsHardwareTransforms`.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25906

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.