D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule
Benjamin Port <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
bport added inline comments.
INLINE COMMENTS
> virtualdesktops.cpp:180
>
> - if (m_navWraps != m_settings->rollOverDesktop()) {
> - needsSave = true;
> - }
> -
> - if (m_osdEnabled != m_settings->desktopChangeOsdEnabled()) {
> - needsSave = true;
> - }
> -
> - if (m_osdDuration != m_settings->popupHideDelay()) {
> - needsSave = true;
> - }
> -
> - if (m_osdTextOnly != m_settings->textOnly()) {
> - needsSave = true;
> - }
> -
> - setNeedsSave(needsSave);
> + return needsSave;
> }
I think we can simplify the whole method by
return m_desktopsModel->needsSave() || m_animationsModel->needsSave();
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D25881
To: meven, #kwin, ervin, crossi
Cc: bport, crossi, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart