D26172: Add wp_viewporter support

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> scene_qpainter.cpp:294
>          // special case for XWayland windows
> -        source = QRect(toplevel->clientPos(), toplevel->clientSize());
> +        const QRectF viewportRectangle = toplevel->surface()->sourceRectangle();
> +        if (viewportRectangle.isValid()) {

This will crash on X and internal clients.

> scene_qpainter.cpp:308
> +                            viewportRectangle.bottomRight() * imageScale);
> +        } else {
> +            source = pixmap->image().rect();

In the GL case you implement a crop if we have a sourceRect with a position and an invalid size

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D26172

To: romangg, #kwin, davidedmundson
Cc: davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart