D18000: Tweak slidingpopups effect to make animation smoother and more consistent
Sefa Eyeoglu <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
sefaeyeoglu added a comment. I commented on D25343 <https://phabricator.kde.org/D25343> about this. Also note the following inline comment. If we decide on (really) "OutQuad" for slide-in and "InQuad" (or "OutQuad" in code), we just need to adjust L467. Maybe we should also add a comment at L506 that the easing curve will be reversed. INLINE COMMENTS > slidingpopups.cpp:506 > animation.timeLine.setDuration((*dataIt).slideOutDuration); > - animation.timeLine.setEasingCurve(QEasingCurve::InOutSine); > + animation.timeLine.setEasingCurve(QEasingCurve::OutQuad); > Technically the "OutQuad" here turns into "InQuad". In L504 the animation is reversed, which also reverses the easing curve. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D18000 To: ngraham, #vdg, zzag, #kwin, sefaeyeoglu, ndavis Cc: niccolove, ngraham, abetts, davidedmundson, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, sebas, apol, ahiemstra, mart