D26381: Port DesktopGrid QtQuickWindow to EffectQuickView

zzag added a comment.


  I'm not able to build kwin with patch
  
    [640/1715] Building CXX object effects/CMakeFiles/kwin4_effect_builtins.dir/kwin4_effect_builtins_autogen/mocs_compilation.cpp.o
    FAILED: effects/CMakeFiles/kwin4_effect_builtins.dir/kwin4_effect_builtins_autogen/mocs_compilation.cpp.o 
    /usr/lib/ccache/bin/c++  -DEFFECT_BUILTINS -DKCOREADDONS_LIB -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_URL_CAST_FROM_STRING -DQT_QMLMODELS_LIB -DQT_QML_LIB -DQT_QUICK_LIB -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_X11EXTRAS_LIB -DQT_XML_LIB -DTRANSLATION_DOMAIN=\"kwin_effects\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkwin4_effect_builtins_EXPORTS -Ieffects -I/home/vlad/Workspace/KDE/src/kde/workspace/kwin/effects -Ieffects/kwin4_effect_builtins_autogen/include -I/home/vlad/Workspace/KDE/src/kde/workspace/kwin/platformsupport -I/home/vlad/Workspace/KDE/src/kde/workspace/kwin/tabbox -I/home/vlad/Workspace/KDE/src/kde/workspace/kwin/libkwineffects -I. -Ilibkwineffects -I/home/vlad/Workspace/KDE/src/kde/workspace/kwin -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KConfigGui -isystem /home/vlad/Workspace/KDE/usr/include/KF5 -isystem /home/vlad/Workspace/qt5/qtbase/include -isystem /home/vlad/Workspace/qt5/qtbase/include/QtGui -isystem /home/vlad/Workspace/qt5/qtbase/include/QtCore -isystem /home/vlad/Workspace/qt5/qtbase/./mkspecs/linux-g++ -isystem /home/vlad/Workspace/qt5/qtbase/include/QtXml -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KConfigCore -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KConfigWidgets -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KCodecs -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KWidgetsAddons -isystem /home/vlad/Workspace/qt5/qtbase/include/QtWidgets -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KAuth -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KCoreAddons -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KGlobalAccel -isystem /home/vlad/Workspace/qt5/qtbase/include/QtDBus -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KI18n -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KIconThemes -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KNotifications -isystem /home/vlad/Workspace/KDE/usr/include/KF5/Plasma -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KService -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KPackage -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KWindowSystem -isystem /home/vlad/Workspace/qt5/qtbase/include/QtQuick -isystem /home/vlad/Workspace/qt5/qtbase/include/QtQmlModels -isystem /home/vlad/Workspace/qt5/qtbase/include/QtQml -isystem /home/vlad/Workspace/qt5/qtbase/include/QtNetwork -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KDeclarative -isystem /home/vlad/Workspace/KDE/usr/include/KF5/KWayland/Server -isystem /home/vlad/Workspace/qt5/qtbase/include/QtConcurrent -isystem /home/vlad/Workspace/qt5/qtbase/include/QtX11Extras -pipe -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -fdiagnostics-color=always -g -fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -fPIC -std=gnu++14 -MD -MT effects/CMakeFiles/kwin4_effect_builtins.dir/kwin4_effect_builtins_autogen/mocs_compilation.cpp.o -MF effects/CMakeFiles/kwin4_effect_builtins.dir/kwin4_effect_builtins_autogen/mocs_compilation.cpp.o.d -o effects/CMakeFiles/kwin4_effect_builtins.dir/kwin4_effect_builtins_autogen/mocs_compilation.cpp.o -c effects/kwin4_effect_builtins_autogen/mocs_compilation.cpp
    In file included from effects/kwin4_effect_builtins_autogen/mocs_compilation.cpp:12:
    effects/kwin4_effect_builtins_autogen/OGFQ2SQVNZ/moc_flipswitch.cpp: In static member function ‘static void KWin::FlipSwitchEffect::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)’:
    effects/kwin4_effect_builtins_autogen/OGFQ2SQVNZ/moc_flipswitch.cpp:130:85: error: invalid use of incomplete type ‘class QKeySequence’
      130 |         case 2: _t->globalShortcutChanged((*reinterpret_cast< QAction*(*)>(_a[1])),(*reinterpret_cast< QKeySequence(*)>(_a[2]))); break;
          |                                                                                    ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    In file included from /home/vlad/Workspace/qt5/qtbase/include/QtCore/qmetatype.h:1,
                     from /home/vlad/Workspace/qt5/qtbase/src/corelib/kernel/qobject.h:54,
                     from /home/vlad/Workspace/qt5/qtbase/include/QtCore/qobject.h:1,
                     from /home/vlad/Workspace/qt5/qtbase/src/corelib/kernel/qcoreapplication.h:46,
                     from /home/vlad/Workspace/qt5/qtbase/include/QtCore/qcoreapplication.h:1,
                     from /home/vlad/Workspace/qt5/qtbase/include/QtCore/QCoreApplication:1,
                     from /home/vlad/Workspace/KDE/src/kde/workspace/kwin/libkwineffects/kwinglobals.h:24,
                     from /home/vlad/Workspace/KDE/src/kde/workspace/kwin/libkwineffects/kwineffects.h:29,
                     from /home/vlad/Workspace/KDE/src/kde/workspace/kwin/effects/backgroundcontrast/contrast.h:24,
                     from effects/kwin4_effect_builtins_autogen/34U44GHX75/moc_contrast.cpp:10,
                     from effects/kwin4_effect_builtins_autogen/mocs_compilation.cpp:2:
    /home/vlad/Workspace/qt5/qtbase/src/corelib/kernel/qmetatype.h:1999:1: note: forward declaration of ‘class QKeySequence’
     1999 | QT_FOR_EACH_STATIC_GUI_CLASS(QT_FORWARD_DECLARE_STATIC_TYPES_ITER)
          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    In file included from effects/kwin4_effect_builtins_autogen/OGFQ2SQVNZ/moc_flipswitch.cpp:10,
                     from effects/kwin4_effect_builtins_autogen/mocs_compilation.cpp:12:
    /home/vlad/Workspace/KDE/src/kde/workspace/kwin/effects/flipswitch/flipswitch.h:89:62: note:   initializing argument 2 of ‘void KWin::FlipSwitchEffect::globalShortcutChanged(QAction*, QKeySequence)’
       89 |     void globalShortcutChanged(QAction *action, QKeySequence shortcut);
          |                                                 ~~~~~~~~~~~~~^~~~~~~~
  
  Qt version: 5.15

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D26381

To: davidedmundson, #kwin
Cc: meven, zzag, kwin, iasensio, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart