D26381: Port DesktopGrid QtQuickWindow to EffectQuickView
Vlad Zahorodnii <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added a comment.
Sweet! Desktop grid buttons look good during transitions, although they are smaller than used to be. Not a big problem, though.
INLINE COMMENTS
> desktopgrid.cpp:105
> {
> - foreach (DesktopButtonsView *view, m_desktopButtonsViews)
> + for (auto *view: m_desktopButtonsViews)
> view->deleteLater();
Please don't use `auto` here, it obfuscates code rather than erases redundancy. Also, there has to be whitespace before `:`.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D26381
To: davidedmundson, #kwin
Cc: meven, zzag, kwin, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart