Re: Revert of my compositing rework patches

On Wed, Jan 15, 2020 at 7:10 PM Vlad Zahorodnii <[email protected]> wrote:
>
> Hi,
>
> On 1/15/20 7:28 PM, Roman Gilg wrote:
> > Reasons for reverting are:
> > * The Nvidia swap event patch hasn't yet landed to optimize in that case.
>
> If my memory serves me well, someone suggested you to commandeer that
> revision and Fredrik didn't object to that.

Yea I remember, but I worked on other stuff since then. Also I haven't
tested since then on Nvidia again the compositing so I can't say how
necessary the optimization is. The last time I tested it somewhat in
November it felt alright and I haven't seen any negative feedback from
Nvidia users on master branch since then. But there might be no users.
Ok, you are afaik as of late one so I assume you would have said
something if the situation was unbearable. But your specific setup is
not everyone's Nvidia setup of course.

> > * Some minor regressions had been crept up and there might be more.
>
> Well, they can always be fixed. ;-)

The regressions I meant had been fixed already. But this doesn't mean
there are not any others that have not yet been discovered and the
ones already found and fixed could be read as an indicator that there
will be more. That's again a question of risk acceptance.

> > * My patches weren't formally accepted when I landed them, another
> > maintainer complained about that.
> > * I don't see a positive future for the KWin project as it is currently
> > organized on a fundamental level. Because of this I don't want to maintain
> > these large code changes ongoing.
>
> Yes, we need to do something our workflow. Have you seen David's
> workflow proposal?

Do you mean the separate branch he mentioned in his email in this
chain? I haven't seen another more elaborate proposal if you mean
something like that instead.

> > Simple yes/no from the other two maintainers is enough. If they both want
> > to keep the compositing rework patches in one of them is responsible for
> > acting on related bug reports afterwards. If not both agree there is no
> > consensus on the compositing rework and I will revert the patches before
> > tomorrow 10:00am Berlin time so they don't go into the 5.18 beta. In case
> > of subsequent issues because of the revert itself I will act on these
> > myself.
>
> If you think it's better to revert these patches, then let's do it.
>
> Cheers,
> Vlad