D26381: Port DesktopGrid QtQuickWindow to EffectQuickView

zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> desktopgrid.cpp:194
>      // paint the add desktop button
> -    foreach (DesktopButtonsView *view, m_desktopButtonsViews) {
> -        if (!view->effectWindow) {
> -            EffectWindow *viewWindow = effects->findWindow(view->winId());
> -            if (viewWindow) {
> -                viewWindow->setData(WindowForceBlurRole, QVariant(true));
> -                view->effectWindow = viewWindow;
> -            }
> -        }
> -        if (view->effectWindow) {
> -            WindowPaintData d(view->effectWindow);
> -            d.multiplyOpacity(timeline.currentValue());
> -            effects->drawWindow(view->effectWindow, PAINT_WINDOW_TRANSLUCENT, infiniteRegion(), d);
> -        }
> +    for (EffectQuickScene* view : m_desktopButtons) {
> +        view->rootItem()->setOpacity(timeline.currentValue());

Align `*` to right.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26381

To: davidedmundson, #kwin, zzag
Cc: meven, zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart