D26859: Implement the tablet wayland protocol in kwin

Vlad Zahorodnii <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag accepted this revision.
zzag added a subscriber: davidedmundson.
zzag added a comment.
This revision is now accepted and ready to land.


  Code-wise, +1
  
  Please wait for a +1 from @davidedmundson

INLINE COMMENTS

> input.cpp:1554
> +
> +    void integrateDevice(LibInput::Device *device)
> +    {

Naming nitpick: maybe `addDevice`?

> input_event.h:193
> +    quint64 serialId() const { return m_serialId; }
> +    QString tabletSysName() { return m_tabletSysName; }
> +

Make it `const`?

REPOSITORY
  R108 KWin

BRANCH
  apol/tablet-unstable-v2-1

REVISION DETAIL
  https://phabricator.kde.org/D26859

To: apol, #kwin, #plasma, zzag
Cc: davidedmundson, zzag, kwin, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.