D27050: Use QRect::moveRight() and QRect::moveBottom() in XdgShellClient::transientPlacement()

Kai Uwe Broulik <[email protected]> Fri, 31 Jan 2020 08:18:09 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

broulik added inline comments.

INLINE COMMENTS

> xdgshellclient.cpp:1710
>          if (!inBounds(popupPosition, Qt::RightEdge)) {
> -            // moveRight suffers from the classic QRect off by one issue
> -            popupPosition.moveLeft(bounds.x() + bounds.width() - size.width());

So what is this comment about then?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27050

To: zzag, #kwin
Cc: broulik, kwin, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart