D10041: Decode full monitor vendor name from EDID using hwdata
Christophe Giboudeaux <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
cgiboudeaux added inline comments. INLINE COMMENTS > Findhwdata.cmake:37 > + find_file(hwdata_PNPIDS_FILE NAMES hwdata/pnp.ids HINTS /usr/share) > + if (hwdata_DIR-NOTFOUND OR hwdata_PNPIDS_FILE-NOTFOUND) > + set(hwdata_FOUND FALSE) The correct syntax is `if (NOT hwdata_DIR_NAMES OR NOT hwdata_PNPIDS_FILE)` -NOTFOUND evaluates to FALSE [1] [1] https://cmake.org/cmake/help/latest/command/if.html REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10041 To: dvratil, graesslin, davidedmundson, #plasma Cc: cgiboudeaux, apol, feverfew, ngraham, davidedmundson, mart, kwin, sebas, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, ahiemstra