D27729: fix: make hwdata truly a runtime dependency
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> edid.cpp:148
> // Map to vendor name
> - QFile pnpFile(QStringLiteral(HWDATA_PNPIDS_FILE));
> + QFile pnpFile(QStringLiteral("/usr/share/hwdata/pnp.ids"));
> if (pnpFile.exists() && pnpFile.open(QIODevice::ReadOnly)) {
You can't hardcode /use/share
If we do go runtime only, please use QStandardPaths
Though I don't yet fully understand the need to avoid the compile time switch, there were comments on what to fix in the last patch.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D27729
To: dvratil, #plasma, ngraham, davidedmundson
Cc: davidedmundson, zzag, ngraham, kwin, cgiboudeaux, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart