D27778: Use AbstractClient instead of XdgShellClient wherever possible

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
zzag requested review of this revision.

REVISION SUMMARY
  Currently, we have only one shell client type - XdgShellClient. We use
  it when we are dealing with Wayland clients. But it isn't really a good
  idea because we may need to support shell surfaces other than xdg-shell
  ones, for example input panel surfaces.
  
  In order to make kwin more extensible, this change replaces all usages
  of the XdgShellClient class with the AbstractClient class.

TEST PLAN
  Existing tests pass.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D27778

AFFECTED FILES
  abstract_client.cpp
  abstract_client.h
  autotests/integration/activation_test.cpp
  autotests/integration/activities_test.cpp
  autotests/integration/buffer_size_change_test.cpp
  autotests/integration/dbus_interface_test.cpp
  autotests/integration/debug_console_test.cpp
  autotests/integration/decoration_input_test.cpp
  autotests/integration/desktop_window_x11_test.cpp
  autotests/integration/dont_crash_aurorae_destroy_deco.cpp
  autotests/integration/dont_crash_cancel_animation.cpp
  autotests/integration/dont_crash_cursor_physical_size_empty.cpp
  autotests/integration/dont_crash_empty_deco.cpp
  autotests/integration/dont_crash_no_border.cpp
  autotests/integration/dont_crash_reinitialize_compositor.cpp
  autotests/integration/dont_crash_useractions_menu.cpp
  autotests/integration/effects/desktop_switching_animation_test.cpp
  autotests/integration/effects/fade_test.cpp
  autotests/integration/effects/maximize_animation_test.cpp
  autotests/integration/effects/minimize_animation_test.cpp
  autotests/integration/effects/popup_open_close_animation_test.cpp
  autotests/integration/effects/scripted_effects_test.cpp
  autotests/integration/effects/slidingpopups_test.cpp
  autotests/integration/effects/toplevel_open_close_animation_test.cpp
  autotests/integration/effects/translucency_test.cpp
  autotests/integration/effects/windowgeometry_test.cpp
  autotests/integration/effects/wobbly_shade_test.cpp
  autotests/integration/generic_scene_opengl_test.cpp
  autotests/integration/globalshortcuts_test.cpp
  autotests/integration/idle_inhibition_test.cpp
  autotests/integration/input_stacking_order.cpp
  autotests/integration/internal_window.cpp
  autotests/integration/keyboard_layout_test.cpp
  autotests/integration/keymap_creation_failure_test.cpp
  autotests/integration/kwin_wayland_test.h
  autotests/integration/kwinbindings_test.cpp
  autotests/integration/lockscreen.cpp
  autotests/integration/maximize_test.cpp
  autotests/integration/move_resize_window_test.cpp
  autotests/integration/placement_test.cpp
  autotests/integration/plasma_surface_test.cpp
  autotests/integration/plasmawindow_test.cpp
  autotests/integration/pointer_constraints_test.cpp
  autotests/integration/pointer_input.cpp
  autotests/integration/quick_tiling_test.cpp
  autotests/integration/scene_opengl_shadow_test.cpp
  autotests/integration/scene_qpainter_shadow_test.cpp
  autotests/integration/scene_qpainter_test.cpp
  autotests/integration/screenedge_client_show_test.cpp
  autotests/integration/scripting/minimizeall_test.cpp
  autotests/integration/shade_test.cpp
  autotests/integration/showing_desktop_test.cpp
  autotests/integration/stacking_order_test.cpp
  autotests/integration/struts_test.cpp
  autotests/integration/tabbox_test.cpp
  autotests/integration/test_helpers.cpp
  autotests/integration/touch_input_test.cpp
  autotests/integration/transient_placement.cpp
  autotests/integration/virtual_desktop_test.cpp
  autotests/integration/window_rules_test.cpp
  autotests/integration/window_selection_test.cpp
  autotests/integration/x11_client_test.cpp
  autotests/integration/xdgshellclient_rules_test.cpp
  autotests/integration/xdgshellclient_test.cpp
  autotests/integration/xwayland_input_test.cpp
  autotests/integration/xwayland_selections_test.cpp
  composite.cpp
  debug_console.cpp
  debug_console.h
  effects.cpp
  effects.h
  idle_inhibition.cpp
  idle_inhibition.h
  input.cpp
  layers.cpp
  plugins/platforms/drm/egl_stream_backend.h
  pointer_input.cpp
  popup_input_filter.cpp
  popup_input_filter.h
  scripting/scripting_model.cpp
  thumbnailitem.cpp
  useractions.cpp
  virtualkeyboard.cpp
  wayland_server.cpp
  wayland_server.h
  workspace.cpp
  workspace.h
  xdgshellclient.cpp
  xdgshellclient.h

To: zzag, #kwin
Cc: kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart